Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance e2e for restart api-server case #1335

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Apr 28, 2024

When egresss e2e, daemonset will be started for testing. The startup timeout was originally set to 30s. I observed that it does start slowly. I adjusted the timeout and added a detailed debug log.

@lou-lan lou-lan added the pr/not-ready not ready for merging label Apr 28, 2024
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (f188111) to head (2205a04).
Report is 14 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1335   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files          20       20           
  Lines        2560     2560           
=======================================
  Hits         2186     2186           
  Misses        266      266           
  Partials      108      108           
Flag Coverage Δ
unittests 85.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lou-lan lou-lan force-pushed the enhance-e2e-for-restart-apiserver branch from 3d1cc63 to 833de35 Compare April 28, 2024 11:22
@lou-lan lou-lan added release/bug bug pr recoded in new release and removed pr/not-ready not ready for merging labels Apr 28, 2024
Signed-off-by: lou-lan <loulan@loulan.me>
@lou-lan lou-lan force-pushed the enhance-e2e-for-restart-apiserver branch from 833de35 to 2205a04 Compare April 28, 2024 11:25
@weizhoublue weizhoublue merged commit fd0beb0 into main Apr 28, 2024
32 checks passed
@weizhoublue weizhoublue deleted the enhance-e2e-for-restart-apiserver branch April 28, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/bug bug pr recoded in new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants