Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemoveFinalizers to improve code reusability #1248

Merged
merged 1 commit into from
Mar 11, 2024

Refactor RemoveFinalizers to improve code reusability

4991e89
Select commit
Loading
Failed to load commit list.
Merged

Fix RemoveFinalizers to improve code reusability #1248

Refactor RemoveFinalizers to improve code reusability
4991e89
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 7, 2024 in 1s

84.16% (target 5.00%)

View this Pull Request on Codecov

84.16% (target 5.00%)

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.16%. Comparing base (c57fde2) to head (4991e89).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1248   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files          19       20    +1     
  Lines        3170     3171    +1     
=======================================
+ Hits         2668     2669    +1     
  Misses        390      390           
  Partials      112      112           
Files Coverage Δ
pkg/utils/finalizers.go 100.00% <100.00%> (ø)
pkg/controller/tunnel/egress_tunnel.go 40.16% <0.00%> (-0.61%) ⬇️