Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize egress gateway controller reconcile logic #1243

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Mar 4, 2024

Optimize egress gateway controller reconcile logic for improved performance.

Fix #1217
Fix #1207

@lou-lan lou-lan added the pr/not-ready not ready for merging label Mar 4, 2024
@weizhoublue
Copy link
Collaborator

weizhoublue commented Mar 4, 2024

@weizhoublue weizhoublue temporarily deployed to pull request March 4, 2024 14:58 Inactive
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (da02473) to head (c9c5cda).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   84.25%   84.16%   -0.10%     
==========================================
  Files          19       19              
  Lines        3170     3170              
==========================================
- Hits         2671     2668       -3     
- Misses        388      390       +2     
- Partials      111      112       +1     
Flag Coverage Δ
unittests 84.16% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@weizhoublue weizhoublue temporarily deployed to pull request March 5, 2024 05:14 Inactive
@weizhoublue weizhoublue temporarily deployed to pull request March 5, 2024 05:47 Inactive
@weizhoublue weizhoublue temporarily deployed to pull request March 5, 2024 07:06 Inactive
@lou-lan lou-lan added the release/none should not recoded in new release label Mar 5, 2024
@weizhoublue weizhoublue temporarily deployed to pull request March 5, 2024 07:31 Inactive
@lou-lan lou-lan force-pushed the update-controller branch 2 times, most recently from 7dd2fd3 to e124dd6 Compare March 5, 2024 08:30
@lou-lan lou-lan added release/bug bug pr recoded in new release and removed pr/not-ready not ready for merging release/none should not recoded in new release labels Mar 5, 2024
@lou-lan lou-lan requested a review from bzsuni March 5, 2024 09:20
Signed-off-by: lou-lan <loulan@loulan.me>
@lou-lan lou-lan merged commit b9918cc into main Mar 6, 2024
32 checks passed
@lou-lan lou-lan deleted the update-controller branch March 6, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/bug bug pr recoded in new release
Projects
None yet
3 participants