Update EgressGateway validation #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
=======================================
Coverage 61.71% 61.71%
=======================================
Files 17 17
Lines 3025 3025
=======================================
Hits 1867 1867
Misses 918 918
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. |
weizhoublue
reviewed
Jan 21, 2024
|
|
||
| return webhook.Allowed("checked") | ||
| func checkDupIP(currentIPv4List, currentIPv6List []net.IP, clusterIPMap map[string]map[string]struct{}) error { |
There was a problem hiding this comment.
这个 api 应该在 utiles 之类的 pkg 中出现更为合适 ，让它 更具通用性
There was a problem hiding this comment.
这个函数目前放在 webhook 的这个文件中更好，不需要放在 utiles 之类中。该函数不需要通用性。
|
目前已经是比较正式的版本了，每个 bug 修复，会呈现在 release note ， 都需要有一些 描述：以前是什么，纠正是什么 |
done |
weizhoublue
approved these changes
Jan 22, 2024
bzsuni
approved these changes
Jan 24, 2024
Signed-off-by: lou-lan <loulan@loulan.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #839
Fix #538
Before
can create egressgateway ippools IP repeat
After
cannot create egressgateway ippools IP repeat