Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check eip in dual stack #1037

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix check eip in dual stack #1037

merged 1 commit into from
Dec 6, 2023

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Dec 6, 2023

Fix #1036

@lou-lan lou-lan requested a review from bzsuni December 6, 2023 04:25
@lou-lan lou-lan added the release/bug bug pr recoded in new release label Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #1037 (e776ef3) into main (467deb2) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 12.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
- Coverage   44.44%   44.43%   -0.02%     
==========================================
  Files          21       21              
  Lines        3260     3261       +1     
==========================================
  Hits         1449     1449              
- Misses       1605     1606       +1     
  Partials      206      206              
Flag Coverage Δ
unittests 44.43% <12.50%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/controller/webhook/validate.go 60.00% <12.50%> (-0.22%) ⬇️

@lou-lan lou-lan merged commit 30001c6 into main Dec 6, 2023
33 of 34 checks passed
@lou-lan lou-lan deleted the fix-1036 branch December 6, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/bug bug pr recoded in new release
Projects
None yet
2 participants