Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoder improvements #1885

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Encoder improvements #1885

merged 3 commits into from
Jul 23, 2024

Conversation

sagikazarmark
Copy link
Collaborator

Fixes #856

@sagikazarmark
feat: drop config type switch from marshaling
11796f7 
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark
refactor: replace string slice search with slices package
7f20152 
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark
feat: add function to write config to writer
90ff08a 
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark added the kind/enhancement New feature or request label Jul 20, 2024
@sagikazarmark sagikazarmark mentioned this pull request Jul 20, 2024
Closed
Repository owner deleted a comment from github-actions bot Jul 20, 2024
@sagikazarmark sagikazarmark merged commit ae564f0 into master Jul 23, 2024
29 checks passed
@sagikazarmark sagikazarmark deleted the encoder-list branch July 23, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we have a func WriteConfig...(w io.Writer) error?
1 participant
@sagikazarmark