Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing config type when reading from a buffer #1857

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

sagikazarmark
Copy link
Collaborator

@sagikazarmark sagikazarmark commented Jun 5, 2024

Return an error from ReadConfig and MergeConfig when no config type is set.

Fixes #1784

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark added the kind/bug Something isn't working label Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

👋 Thanks for contributing to Viper! You are awesome! 🎉

A maintainer will take a look at your pull request shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@sagikazarmark sagikazarmark changed the title Fix missing config type Fix missing config type when reading from a buffer Jun 5, 2024
@sagikazarmark sagikazarmark merged commit a42c1b9 into master Jun 5, 2024
29 checks passed
@sagikazarmark sagikazarmark deleted the fix-missing-config-type branch June 5, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadConfig(in io.Reader) does not Actually ReadConfig
1 participant