Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have changed
I have applied the
TODO: make this lazy initialization instead
left by @sagikazarmark . The main changes are listed as following:codec
.This change is caused as I try to create a new codec by calling a method of a nil pointer with type. I want the decoder and encoder to share the same object constructed by the method.
constructor.Codec
interface to avoid cycle import.Benchmark
I use this command to run the benchmark across commits:
The output is:
For me, I think this change doesn't reduce the efficiency of
viper
.