Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move cobra/cmd/* to cobra/ #1430

Closed
wants to merge 1 commit into from

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Jun 29, 2021

Currently, subdir cobra contains two sources only (main.go and Makefile). Most of the actual sources fo the CLI are located in cobra/cmd. IMHO, that can be misleading because cobra is not meant to be extended in-place. Having most of the sources as package cmd implies that main.go might use other packages, which is not the case. I think this is a remainder of the initial layout of the repo, when cobra CLI was the only available example about how to use cobra (the library). Nowadays, there are plenty of examples. Nonethless, that belongs to the documentation.

This PR moves cobra/cmd/* to cobra/* and merges root.go into main.go.

@github-actions github-actions bot added the area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli label Jun 29, 2021
@umarcor umarcor force-pushed the refactor-cobra branch 2 times, most recently from 8ee2f78 to ae67f41 Compare July 1, 2021 17:55
@umarcor umarcor mentioned this pull request Jul 2, 2021
@github-actions
Copy link

github-actions bot commented Oct 4, 2021

This PR is being marked as stale due to a long period of inactivity

@umarcor umarcor force-pushed the refactor-cobra branch 2 times, most recently from 16f853c to 31779ae Compare November 3, 2021 20:31
umarcor added a commit to umarcor/cobra that referenced this pull request Nov 4, 2021
@umarcor umarcor force-pushed the refactor-cobra branch 2 times, most recently from 5d87b4a to 2d3794e Compare November 16, 2021 22:40
umarcor added a commit to umarcor/cobra that referenced this pull request Nov 16, 2021
@umarcor umarcor force-pushed the refactor-cobra branch 2 times, most recently from 849ff14 to bec621a Compare December 10, 2021 00:23
umarcor added a commit to umarcor/cobra that referenced this pull request Dec 10, 2021
umarcor added a commit to umarcor/cobra that referenced this pull request Dec 10, 2021
umarcor added a commit to umarcor/cobra that referenced this pull request Dec 14, 2021
@umarcor umarcor force-pushed the refactor-cobra branch 2 times, most recently from a9f935e to 5715486 Compare February 18, 2022 04:58
@jpmcb
Copy link
Collaborator

jpmcb commented Feb 24, 2022

Thanks for the thoughtful PR!

This is being superseded by: #1604 as cobra/ is being moved to spf13/cobra-cli

For further reference: #1597

@jpmcb jpmcb closed this Feb 24, 2022
@jpmcb jpmcb added lifecycle/wont-do For issues and PRs the community has determined are not a priority and will not execute against and removed area/cli labels Feb 24, 2022
@umarcor
Copy link
Contributor Author

umarcor commented Feb 25, 2022

See spf13/cobra-cli#8.

@umarcor umarcor deleted the refactor-cobra branch February 25, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli [deprecated] For the cobra CLI !!! moved to spf13/cobra-cli lifecycle/wont-do For issues and PRs the community has determined are not a priority and will not execute against
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants