-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(command): adding args to use line #1210
base: main
Are you sure you want to change the base?
Conversation
This PR is being marked as stale due to a long period of inactivity |
@jpmcb could you take a look? |
Ref #842 |
Hi @danmx thanks for this PR - would you be able to add a test for this? Maybe in |
fc97c0c
to
e481b1f
Compare
@jpmcb took me some time but I've added tests for |
0179759
to
64cff20
Compare
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
@marckhouzam I see that you were active recently. Could you take a look at this PR? I addressed the previous comment about adding tests. |
Signed-off-by: danmx <daniel.iziourov@elastic.co>
Signed-off-by: danmx <daniel@iziourov.info>
This PR exceeds the recommended size of 200 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Adding
args
to use line