Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wildcards with capture groups #472

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Fixes wildcards with capture groups #472

merged 1 commit into from
Apr 19, 2018

Conversation

msjonker
Copy link
Contributor

Currently, if a capture group is directly after a wildcard, the wildcard terms are added to the capture group. Additionally, wildcard capture groups return the entire match, instead of just the wildcard terms.

This only applies capture group settings to the term if the term is a match, and also applies capture group settings for wildcards to the wildcard matching terms.

@spencermountain spencermountain changed the base branch from master to dev April 19, 2018 23:18
@spencermountain spencermountain changed the base branch from dev to master April 19, 2018 23:18
@spencermountain spencermountain changed the base branch from master to dev April 19, 2018 23:19
@spencermountain
Copy link
Owner

hey Matt, thanks. makes sense.
I've put it on dev cause some tests are failing. no big, i'll check em out.
nice one!

@spencermountain spencermountain merged commit 654f087 into spencermountain:dev Apr 19, 2018
@spencermountain spencermountain mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants