Verify discard unpacked layers setting #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillebaba
force-pushed
the
verify-discard-unpacked-layers
branch
from
e7c1f24
to
53769e8
Compare
t1mt
pushed a commit
to t1mt/spegel
that referenced
this pull request
Sep 3, 2024
…d-layers Verify discard unpacked layers setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It became clear in #217 that Spegel works very poorly if Containerd discard unpacked layers is enabled. When it is enabled any layer that is not required to run the container will be discarded. It defeats the purpose of Spegel which needs these layers present to distribute.
By default this is disabled. However it was recently enabled in EKS by default causing issues for some users.
awslabs/amazon-eks-ami#1360
This change implements a check for this setting and exits if it is enabled. This will hopefully inform users in the future if the setting has been enabled.