Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable-Speedb-Feature: Use Scoped Pinning Policy instead of Default Policy #715

Merged

Conversation

udi-speedb
Copy link
Contributor

No description provided.

@udi-speedb udi-speedb force-pushed the 628-add-tablepinningpolicy-to-enablespeedbfeaturescf-function branch from 687b2f1 to 440b40c Compare October 13, 2023 08:12
@udi-speedb
Copy link
Contributor Author

@erez-speedb - Please run performance tests on the branch. Thanks

@hilikspdb
Copy link
Contributor

@udi-speedb the pinning policy must be shared object between all the CF (and not recreated per CF) .. sorry that i have missed it

Copy link
Contributor

@hilikspdb hilikspdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pinning must be a shared object (like the cache) sorry that I have missed it...

@udi-speedb
Copy link
Contributor Author

@udi-speedb the pinning policy must be shared object between all the CF (and not recreated per CF) .. sorry that i have missed it

@hilikspdb - Indeed you are correct. I have also missed that.

Copy link
Contributor

@hilikspdb hilikspdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@Yuval-Ariel Yuval-Ariel self-requested a review October 17, 2023 12:09
@udi-speedb udi-speedb closed this Oct 17, 2023
@udi-speedb udi-speedb reopened this Oct 17, 2023
@udi-speedb udi-speedb merged commit 5bf9c60 into main Oct 17, 2023
13 checks passed
@Yuval-Ariel Yuval-Ariel deleted the 628-add-tablepinningpolicy-to-enablespeedbfeaturescf-function branch October 17, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TablePinningPolicy to EnableSpeedbFeaturesCF function
5 participants