Fix log trace of Block Cache (Entry) Stats dump (#577) #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuval-Ariel
approved these changes
Jun 25, 2023
Yuval-Ariel
reviewed
Jun 25, 2023
db/internal_stats.cc
Outdated
| @@ -739,7 +740,7 @@ std::string InternalStats::CacheEntryRoleStats::ToString( | |||
| << (100.0 * total_charges[i] / cache_capacity) << "%)"; | |||
| } | |||
| } | |||
| str << "\n"; | |||
| str << '\n'; | |||
There was a problem hiding this comment.
why is this necessary?
There was a problem hiding this comment.
Without it the next dump entity comes without any separating spaces. Makes it harder to read for a human.
There was a problem hiding this comment.
i remind you that we've discussed that this change should be removed
There was a problem hiding this comment.
Forced pushed the update
udi-speedb
force-pushed
the
577-block-cache-stats-are-printed-to-the-log-on-the-same-line-as-write-stall-count-log-trace
branch
from
50190a8
to
d23e40a
Compare
Yuval-Ariel
deleted the
577-block-cache-stats-are-printed-to-the-log-on-the-same-line-as-write-stall-count-log-trace
branch
udi-speedb
added a commit
that referenced
this pull request
Nov 22, 2023
udi-speedb
added a commit
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.