db_bench: Create a WBM once for all db-s regardless of their use in different groups (#550) #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuval-Ariel
reviewed
Jun 12, 2023
tools/db_bench_tool.cc
Outdated
Comment on lines
108
to
109
| #include "util/string_util.h" | ||
|
|
|
rest LGTM |
udi-speedb
force-pushed
the
550-db_bench-new-wbm-per-dbs-in-use-in-every-group
branch
from
a2ec570
to
0550e30
Compare
Yuval-Ariel
reviewed
Jun 12, 2023
tools/db_bench_tool.cc
Outdated
| fprintf(stderr, "\nBEFORE Benchmark (%s): %lu OF %lu\n\n", name.c_str(), | ||
| open_options_.write_buffer_manager->memory_usage(), | ||
| open_options_.write_buffer_manager->buffer_size()); | ||
| fprintf(stderr, "\nBEFORE Benchmark (%s): %s OF %s\n\n", name.c_str(), |
There was a problem hiding this comment.
while you're here, can you also add info to the printing that its the WBM's memory you're reporting?
There was a problem hiding this comment.
right now it looks like this:
BEFORE Benchmark (fillseq): 6144 OF 110000000
There was a problem hiding this comment.
Done. And now to the Approve button please
udi-speedb
force-pushed
the
550-db_bench-new-wbm-per-dbs-in-use-in-every-group
branch
from
512c772
to
4a82cec
Compare
…ifferent groups (#550)
udi-speedb
force-pushed
the
550-db_bench-new-wbm-per-dbs-in-use-in-every-group
branch
from
868391b
to
5d77855
Compare
Yuval-Ariel
approved these changes
Jun 12, 2023
Yuval-Ariel
deleted the
550-db_bench-new-wbm-per-dbs-in-use-in-every-group
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.