Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print optimize_filters_for_memory option to the log (#536) #537

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Print optimize_filters_for_memory option to the log (#536) #537

merged 1 commit into from
Jun 11, 2023

Conversation

udi-speedb
Copy link
Contributor

No description provided.

@udi-speedb udi-speedb requested a review from ofriedma June 6, 2023 03:15
@udi-speedb udi-speedb linked an issue Jun 6, 2023 that may be closed by this pull request
optimize_filters_for_memory option is NOT printed to the log #536
Closed
@udi-speedb
Copy link
Contributor Author

udi-speedb commented Jun 6, 2023 •
edited
Loading

@ofriedma - I am not sure there is a better way to sanitize the offm (optimize_filters_for_memory) option.
I have asked @mrambacher for advice in the slack channel, however, I think that we may leave it as is (+ add to the history file + gitbook documentation).
Anyway, I'll wait for @mrambacher's advice and see.
In the meantime, I have opened a separate issue to print the value of offm to the log which is currently missing.

ofriedma
ofriedma approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@ofriedma ofriedma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ofriedma
ofriedma approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@ofriedma ofriedma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yuval-Ariel Yuval-Ariel merged commit 3d4c9d1 into main Jun 11, 2023
@Yuval-Ariel Yuval-Ariel deleted the 536-optimize_filters_for_memory-option-is-not-printed-to-the-log branch June 11, 2023 08:00
udi-speedb added a commit that referenced this pull request Nov 19, 2023
@udi-speedb
LOG: Print optimize_filters_for_memory option to the log (#537)
e41758d
udi-speedb added a commit that referenced this pull request Dec 5, 2023
@udi-speedb
LOG: Print optimize_filters_for_memory option to the log (#537)
0f16d1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofriedma ofriedma ofriedma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

optimize_filters_for_memory option is NOT printed to the log
3 participants
@udi-speedb @ofriedma @Yuval-Ariel