Set initiate_wbm_flushes to the same default value used by the WBM (true) (#480) #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udi-speedb
force-pushed
the
480-set-initiate_wbm_flushes-to-true-in-tools
branch
from
6e937f9
to
44468a5
Compare
Yuval-Ariel
reviewed
May 17, 2023
udi-speedb
force-pushed
the
480-set-initiate_wbm_flushes-to-true-in-tools
branch
from
ef9ec63
to
d522a58
Compare
|
@Yuval-Ariel Please review my latest commit. |
|
@Yuval-Ariel I have pushed the branch 480-set-initiate_wbm_flushes-to-true-in-tools after rebase and conflict resolution |
|
this PR is already closed and merged 😕 |
udi-speedb
added a commit
that referenced
this pull request
Nov 19, 2023
* Set initiate_wbm_flushes to the same default value used by the WBM (true) * Remove sanitizations of wbm flags in the db_bench, db_stress, and db_crashtest.py * Create a WBM unconditionally in db_bench / db_stress (using the applicable flags)
udi-speedb
added a commit
that referenced
this pull request
Dec 5, 2023
* Set initiate_wbm_flushes to the same default value used by the WBM (true) * Remove sanitizations of wbm flags in the db_bench, db_stress, and db_crashtest.py * Create a WBM unconditionally in db_bench / db_stress (using the applicable flags)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that now the user of db_bench / db_stress must either override the default of initiate_wbm_flushes to false or leave it true, but set the db_write_buffer_size flag to a value > 0