Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: Use speedb libs in build_size target #399

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Makefile: Use speedb libs in build_size target #399

merged 1 commit into from
Feb 28, 2023

Conversation

AmnonHanuhov
Copy link
Contributor

Fixes #275

@AmnonHanuhov AmnonHanuhov added the bug fix Fixes a known bug label Feb 13, 2023
@AmnonHanuhov AmnonHanuhov self-assigned this Feb 13, 2023
@AmnonHanuhov AmnonHanuhov linked an issue Feb 13, 2023 that may be closed by this pull request
Makefile: build_size target in the makefile is not adjusted to speedb libs #275
Closed
mrambacher
mrambacher reviewed Feb 13, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@AmnonHanuhov AmnonHanuhov force-pushed the 275-makefile-build_size-target-in-the-makefile-is-not-adjusted-to-speedb-libs branch from 97e0566 to 2c802f9 Compare February 14, 2023 20:28
mrambacher
mrambacher previously approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it works most of the time. However, I think if you said DEBUG_LEVEL=2 make build_size, it might fail. Might want to check that just to be safe.

Otherwise, looks good!

@Yuval-Ariel
Copy link
Contributor

@AmnonHanuhov , do you want to address marks last comment before i merge this?

@AmnonHanuhov
Copy link
Contributor Author

@AmnonHanuhov , do you want to address marks last comment before i merge this?

Yes, I will look into it today.

@AmnonHanuhov
Copy link
Contributor Author

AmnonHanuhov commented Feb 16, 2023 •
edited
Loading

@mrambacher Didn't seem to fail for me with DEBUG_LEVEL=2

@AmnonHanuhov AmnonHanuhov force-pushed the 275-makefile-build_size-target-in-the-makefile-is-not-adjusted-to-speedb-libs branch from 2c802f9 to ddd5445 Compare February 16, 2023 17:53
@AmnonHanuhov AmnonHanuhov force-pushed the 275-makefile-build_size-target-in-the-makefile-is-not-adjusted-to-speedb-libs branch from ddd5445 to 10eac76 Compare February 23, 2023 18:40
mrambacher
mrambacher approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@mrambacher mrambacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yuval-Ariel Yuval-Ariel merged commit 86a6dbf into main Feb 28, 2023
Yuval-Ariel pushed a commit that referenced this pull request May 2, 2023
@AmnonHanuhov @Yuval-Ariel
Makefile: Use speedb libs in build_size target (#399)
8aad2c6
Yuval-Ariel pushed a commit that referenced this pull request May 4, 2023
@AmnonHanuhov @Yuval-Ariel
Makefile: Use speedb libs in build_size target (#399)
35c78db
@Yuval-Ariel Yuval-Ariel deleted the 275-makefile-build_size-target-in-the-makefile-is-not-adjusted-to-speedb-libs branch May 11, 2023 08:26
udi-speedb pushed a commit that referenced this pull request Nov 13, 2023
@AmnonHanuhov @udi-speedb
Makefile: Use speedb libs in build_size target (#399)
90fe078
udi-speedb pushed a commit that referenced this pull request Nov 15, 2023
@AmnonHanuhov @udi-speedb
Makefile: Use speedb libs in build_size target (#399)
0e274aa
udi-speedb pushed a commit that referenced this pull request Dec 4, 2023
@AmnonHanuhov @udi-speedb
Makefile: Use speedb libs in build_size target (#399)
e8874fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrambacher mrambacher mrambacher approved these changes

Assignees

@AmnonHanuhov AmnonHanuhov

Labels
bug fix Fixes a known bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makefile: build_size target in the makefile is not adjusted to speedb libs
3 participants
@AmnonHanuhov @Yuval-Ariel @mrambacher