windows build failed in speedb_paired_bloom_internal files due to bad… #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udi-speedb
previously approved these changes
Feb 2, 2023
ayulas
force-pushed
the
383-compile-windows-warning
branch
3 times, most recently
from
0e4af26
to
ced2418
Compare
|
@ayulas - A preliminary question: Is this PR ready for review with all of the planned changes? |
|
Are all of the changes needed to successfully build on Windows or does this PR contain functional changes that are not related to being able to successfully compile / build on Windows? |
udi-speedb
requested changes
Feb 6, 2023
|
i wouldnt push and send to qa and run CI if it wasnt built successfully and got approve from max |
… used of double / uint32 casting #383
ayulas
force-pushed
the
383-compile-windows-warning
branch
from
ced2418
to
d0e9636
Compare
Yuval-Ariel
approved these changes
Feb 7, 2023
Yuval-Ariel
approved these changes
Feb 7, 2023
udi-speedb
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… used of double / uint32 casting #383