build_version: apply the build tag to the Speedb version string (#231) #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrambacher
approved these changes
Nov 10, 2022
The changes in #157 were accidentally applied to the `GetRocksVersionAsString()` function instead of the `GetSpeedbVersionAsString()` function. This replaced the RocksDB patch number with the Speedb one, and added the build tag in the wrong place. Fix it by moving the logic to the intended function.
isaac-io
force-pushed
the
231-version-the-build-tag-is-incorrectly-added-to-the-rocksdb-version-string
branch
from
039748d
to
28b65fb
Compare
isaac-io
changed the title
Yuval-Ariel
approved these changes
Nov 11, 2022
isaac-io
deleted the
231-version-the-build-tag-is-incorrectly-added-to-the-rocksdb-version-string
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #157 were accidentally applied to the
GetRocksVersionAsString()function instead of theGetSpeedbVersionAsString()function. This replaced the RocksDB patch number with the Speedb one, and added the build tag in the wrong place.Fix it by moving the logic to the intended function.