Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit tests: speedb_db_bloom_filter_test OptimizeFiltersForHits fails #492

Closed
Yuval-Ariel opened this issue May 4, 2023 · 1 comment · Fixed by #538
Closed

unit tests: speedb_db_bloom_filter_test OptimizeFiltersForHits fails #492

Yuval-Ariel opened this issue May 4, 2023 · 1 comment · Fixed by #538
Assignees
@udi-speedb
Labels
bug Something isn't working

Comments

@Yuval-Ariel
Copy link
Contributor

error:

SpdbDBBloomFilterTest.OptimizeFiltersForHits                                                                                    
plugin/speedb/paired_filter/speedb_db_bloom_filter_test.cc:2203: Failure                                                                     
Expected: (TestGetTickerCount(options, BLOOM_FILTER_USEFUL)) > (65000 * 2), actual: 127982 vs 130000

disabled during rebase on 8.1.1
@Yuval-Ariel Yuval-Ariel added the bug Something isn't working label May 4, 2023
@Yuval-Ariel Yuval-Ariel mentioned this issue May 11, 2023
Closed
@Yuval-Ariel Yuval-Ariel mentioned this issue May 26, 2023
Merged
@udi-speedb
Copy link
Contributor

@Yuval-Ariel I have enabled the test and ran it several times on the latest origin/main and the test passes.
I am enabling it.

udi-speedb added a commit that referenced this issue Jun 6, 2023
@udi-speedb
Enabling SpdbDBBloomFilterTest::OptimizeFiltersForHits (#492)
f3c3d5c
@udi-speedb udi-speedb linked a pull request Jun 6, 2023 that will close this issue
Enabling SpdbDBBloomFilterTest::OptimizeFiltersForHits (#492) #538
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@udi-speedb udi-speedb

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabling SpdbDBBloomFilterTest::OptimizeFiltersForHits (#492) speedb-io/speedb
2 participants
@Yuval-Ariel @udi-speedb