Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling WF generate too much logs #461

Closed
erez-speedb opened this issue Apr 4, 2023 · 4 comments · Fixed by #472
Closed

Enabling WF generate too much logs #461

erez-speedb opened this issue Apr 4, 2023 · 4 comments · Fixed by #472
Assignees
Labels
enhancement New feature or request

Comments

@erez-speedb
Copy link

The logs for "normal" large obj test is about 30 MB,
The WF test was over 6 GB.
In the huge 2.5 TB DB test, the logs were so big that the test failed with no space left on the device, meaning ~1 TB of logs.

@erez-speedb erez-speedb added the enhancement New feature or request label Apr 4, 2023
ayulas added a commit that referenced this issue Apr 13, 2023
@erez-speedb erez-speedb linked a pull request Apr 13, 2023 that will close this issue
@erez-speedb
Copy link
Author

The branch reduced the logs back to normal, but also improved performance significantly ??
Small Obj
https://admin.speedb.io/performance?
items=1qSNtYwD7s1rFU6mOjiA&items=bbnH4HiAhbm13TMK0a36&items=KGP7PbR6tEVMduQAmWqW&items=eFKIsbYQ8H7XSkYOLJaM&colors=%23F06292&colors=%23BA68C8&colors=%2300796b&colors=%2300acc1&colors=%23BA68C8

Fillrandom X2 vs the WF before and overwrite is 50% better, makes it almost X3 more than without WF.

Large obj test is running
@Guyme @ayulas @hilikspdb FYI

@ayulas
Copy link
Contributor

ayulas commented Apr 14, 2023 via email

@erez-speedb
Copy link
Author

The large obj shows improved performance as well
https://admin.speedb.io/performance?items=FTIpgmv7fEWBqskYTPwa&items=vbEt4GPWB2TpQnOSCMds&items=XADjyPngf6XHviilpE0V&colors=%23F06292&colors=%23BA68C8&colors=%2300796b

However, the problems also become distinguish, the memory consumption is higher than before and the disk usage is also a scale more than without WF.

@erez-speedb
Copy link
Author

Under the restriction, passed performance tests

@ayulas ayulas changed the title Enabling WF generate to much logs Enabling WF generate too much logs Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants