Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db_bench doesn't support open DBWithTTL() #417

Closed
ofriedma opened this issue Mar 5, 2023 · 1 comment
Closed

db_bench doesn't support open DBWithTTL() #417

ofriedma opened this issue Mar 5, 2023 · 1 comment
Assignees
@ofriedma
Labels
enhancement New feature or request performance tests Tools Usability, performance, functionality - external tools

Comments

@ofriedma
Copy link
Contributor

ofriedma commented Mar 5, 2023 •
edited
Loading

Currently db_bench does not support an option to benchmark DB opened with TTL(Time To Live).
The goal is to add the option for db_bench to open db with ttl, like db_stress could.
Another goal is to add skip_expired_data so it will be able to test strict ttl feature as well.
@ofriedma ofriedma self-assigned this Mar 5, 2023
@ofriedma ofriedma added enhancement New feature or request tests labels Mar 5, 2023
@Guyme Guyme added performance Tools Usability, performance, functionality - external tools labels Mar 5, 2023
ofriedma pushed a commit that referenced this issue Mar 5, 2023
Add support for db_bench to use DBWithTTL::Open()
3e7a325 
Add support for db_bench to use DBWithTTL::Open() just like db_stress.
Add support for using skip_expired_data

Resolves: #417
Pull Request: #403
@ofriedma ofriedma mentioned this issue Mar 15, 2023
Merged
ofriedma pushed a commit that referenced this issue Mar 21, 2023
Add support for db_bench and db_stress to use DBWithTTL::Open()
a836ba2 
Add support for db_bench to use DBWithTTL::Open() just like db_stress.
Add support for using skip_expired_data
Fix bugs in db_stress

Resolves: #417
Pull Request: #403
ofriedma pushed a commit that referenced this issue Apr 3, 2023
Skip expired object when using DBWithTtl
119b336 
Currently even if objects have been expired we still return them until
compaction delete those objects.

This commit adds a skip_expired_data to the ReadOptions, if this option
is true, it Get, MultiGet and iterator will not return objects that have been
expired by the configured ttl.
Currently this feature does not include support of for Merge
operation.
For Read Only and iterator pinned data the skip_expired_data will be enforced and expired keys
will not be returned.

Resolves: #394, #417

Pull Request: #403
ofriedma pushed a commit that referenced this issue Apr 3, 2023
Skip expired object when using DBWithTtl #394
a42ec6c 
Currently even if objects have been expired we still return them until
compaction delete those objects.

This commit adds a skip_expired_data to the ReadOptions, if this option
is true, it Get, MultiGet and iterator will not return objects that have been
expired by the configured ttl.
Currently this feature does not include support of for Merge
operation.
For Read Only and iterator pinned data the skip_expired_data will be enforced and expired keys
will not be returned.

Resolves: #394, #417

Pull Request: #403
Yuval-Ariel pushed a commit that referenced this issue Apr 4, 2023
@ofriedma
TTL: Skip expired object when using DBWithTtl (#403)
df25119 
Currently even if objects have been expired we still return them until
compaction delete those objects.

This commit adds a skip_expired_data to the ReadOptions, if this option
is true, it Get, MultiGet and iterator will not return objects that have been
expired by the configured ttl.
Currently this feature does not include support for Merge operations.
For Read Only and iterator pinned data the skip_expired_data will be 
enforced and expired keys will not be returned.

Resolves: #394, #417

Pull Request: #403
@Yuval-Ariel
Copy link
Contributor

@ofriedma should this be closed since #394 is merged?

@ofriedma ofriedma closed this as completed Apr 4, 2023
Yuval-Ariel pushed a commit that referenced this issue May 2, 2023
@ofriedma @Yuval-Ariel
TTL: Skip expired object when using DBWithTtl (#403)
d226d2b 
Currently even if objects have been expired we still return them until
compaction delete those objects.

This commit adds a skip_expired_data to the ReadOptions, if this option
is true, it Get, MultiGet and iterator will not return objects that have been
expired by the configured ttl.
Currently this feature does not include support for Merge operations.
For Read Only and iterator pinned data the skip_expired_data will be
enforced and expired keys will not be returned.

Resolves: #394, #417

Pull Request: #403
Yuval-Ariel pushed a commit that referenced this issue May 4, 2023
@ofriedma @Yuval-Ariel
TTL: Skip expired object when using DBWithTtl (#403)
fa5eddf 
Currently even if objects have been expired we still return them until
compaction delete those objects.

This commit adds a skip_expired_data to the ReadOptions, if this option
is true, it Get, MultiGet and iterator will not return objects that have been
expired by the configured ttl.
Currently this feature does not include support for Merge operations.
For Read Only and iterator pinned data the skip_expired_data will be
enforced and expired keys will not be returned.

Resolves: #394, #417

Pull Request: #403
udi-speedb pushed a commit that referenced this issue Nov 13, 2023
@ofriedma @udi-speedb
TTL: Skip expired object when using DBWithTtl (#403)
89edc4f 
Currently even if objects have been expired we still return them until
compaction delete those objects.

This commit adds a skip_expired_data to the ReadOptions, if this option
is true, it Get, MultiGet and iterator will not return objects that have been
expired by the configured ttl.
Currently this feature does not include support for Merge operations.
For Read Only and iterator pinned data the skip_expired_data will be
enforced and expired keys will not be returned.

Resolves: #394, #417

Pull Request: #403
udi-speedb pushed a commit that referenced this issue Nov 15, 2023
@ofriedma @udi-speedb
TTL: Skip expired object when using DBWithTtl (#403)
644a752 
Currently even if objects have been expired we still return them until
compaction delete those objects.

This commit adds a skip_expired_data to the ReadOptions, if this option
is true, it Get, MultiGet and iterator will not return objects that have been
expired by the configured ttl.
Currently this feature does not include support for Merge operations.
For Read Only and iterator pinned data the skip_expired_data will be
enforced and expired keys will not be returned.

Resolves: #394, #417

Pull Request: #403
udi-speedb pushed a commit that referenced this issue Dec 4, 2023
@ofriedma @udi-speedb
TTL: Skip expired object when using DBWithTtl (#403)
1a4190d 
Currently even if objects have been expired we still return them until
compaction delete those objects.

This commit adds a skip_expired_data to the ReadOptions, if this option
is true, it Get, MultiGet and iterator will not return objects that have been
expired by the configured ttl.
Currently this feature does not include support for Merge operations.
For Read Only and iterator pinned data the skip_expired_data will be
enforced and expired keys will not be returned.

Resolves: #394, #417

Pull Request: #403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ofriedma ofriedma

Labels
enhancement New feature or request performance tests Tools Usability, performance, functionality - external tools
Projects
Speedb Roadmap
Status: ✅ Shipped
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ofriedma @Yuval-Ariel @Guyme