Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stress fail: when data_block_hash_table_util_ratio is 0 #214

Closed
Yuval-Ariel opened this issue Nov 6, 2022 · 0 comments · Fixed by #215
Closed

stress fail: when data_block_hash_table_util_ratio is 0 #214

Yuval-Ariel opened this issue Nov 6, 2022 · 0 comments · Fixed by #215
Assignees
@Yuval-Ariel

Comments

@Yuval-Ariel
Copy link
Contributor

Describe the bug
open error: Invalid argument: data_block_hash_table_util_ratio should be greater than 0 when data_block_index_type is set to kDataBlockBinaryAndHash

the python script that produces the cmd (tools/db_crashtest.py) for the stress tool can generate value 0 for data_block_hash_table_util_ratio when data_block_index_type is set to kDataBlockBinaryAndHash which is wrong.

fix by limiting range of data_block_hash_table_util_ratio from 0.01 to 1. (instead of 0 to 1)
Yuval-Ariel added a commit that referenced this issue Nov 6, 2022
@Yuval-Ariel
crashtest: fix 0 value of data_block_hash_table_util_ratio (#214)
8f1069d
@Yuval-Ariel Yuval-Ariel mentioned this issue Nov 6, 2022
Merged
@Yuval-Ariel Yuval-Ariel linked a pull request Nov 6, 2022 that will close this issue
crashtest: fix 0 value of data_block_hash_table_util_ratio (#214) #215
Merged
@Yuval-Ariel Yuval-Ariel self-assigned this Nov 6, 2022
Yuval-Ariel added a commit that referenced this issue Nov 6, 2022
@Yuval-Ariel
crashtest: fix 0 value of data_block_hash_table_util_ratio (#214)
9832fc1
Yuval-Ariel added a commit that referenced this issue Nov 15, 2022
@Yuval-Ariel
crashtest: fix 0 value of data_block_hash_table_util_ratio (#214)
ea3ff69
Yuval-Ariel added a commit that referenced this issue Nov 25, 2022
@Yuval-Ariel
crashtest: fix 0 value of data_block_hash_table_util_ratio (#214)
71fe21c
Yuval-Ariel added a commit that referenced this issue Nov 25, 2022
@Yuval-Ariel
crashtest: fix 0 value of data_block_hash_table_util_ratio (#214)
461e6f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yuval-Ariel Yuval-Ariel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

crashtest: fix 0 value of data_block_hash_table_util_ratio (#214) speedb-io/speedb
1 participant
@Yuval-Ariel