Skip to content

Commit

Permalink
Options: Set compaction_readahead_size default to 0 (#792)
Browse files Browse the repository at this point in the history
  • Loading branch information
Yuval-Ariel authored Dec 25, 2023
1 parent 8a38119 commit a1f5abe
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Based on RocksDB 8.6.7

### Miscellaneous
* Remove leftover references to ROCKSDB_LITE (#755).
* Options: Set compaction_readahead_size default to 0. The current default of 2Mb is not optimal for most of our use cases. Having a value of 0 means that the FS will use its default size for prefetching (true only with https://github.com/speedb-io/speedb/pull/788).

## Hazlenut 2.7.0 (27/10/2023)
Based on RocksDB 8.1.1
Expand Down
4 changes: 2 additions & 2 deletions include/rocksdb/options.h
Original file line number Diff line number Diff line change
Expand Up @@ -1005,10 +1005,10 @@ struct DBOptions {
// running RocksDB on spinning disks, you should set this to at least 2MB.
// That way RocksDB's compaction is doing sequential instead of random reads.
//
// Default: 2MB
// Default: 0
//
// Dynamically changeable through SetDBOptions() API.
size_t compaction_readahead_size = 2 * 1024 * 1024;
size_t compaction_readahead_size = 0;

// This is a maximum buffer size that is used by WinMmapReadableFile in
// unbuffered disk I/O mode. We need to maintain an aligned buffer for
Expand Down

0 comments on commit a1f5abe

Please sign in to comment.