Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new "direct" biblio display style #2191

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

brycelelbach
Copy link
Contributor

Add a new biblio display style, "direct", which displays references by their shortname and links to the referenced document. Closes #2032.

@brycelelbach brycelelbach force-pushed the biblio-display-style-direct branch 3 times, most recently from c46a7ef to 0125332 Compare December 6, 2021 19:46
docs/index.bs Outdated Show resolved Hide resolved
docs/index.bs Outdated Show resolved Hide resolved
Copy link
Collaborator

@tabatkins tabatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature looks good. Only problem is the busted indents in the docs, which'll break the formatting when I actually process them.

When you fix those, would you mind running Bikeshed over it and including the results in the PR, too?

@brycelelbach
Copy link
Contributor Author

D'oh. Looks like I missed the fact that the docs use tabs! I was wondering if I should regenerate them.

I've fixed the indents and added regenerated docs to the PR. I also rebased on main (and regenerated the tests and docs afterwards just to be safe).

@tabatkins tabatkins merged commit 1f16618 into speced:main Dec 15, 2021
@brycelelbach
Copy link
Contributor Author

Thanks!

@brycelelbach brycelelbach deleted the biblio-display-style-direct branch December 16, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to allow inline linking to use shortnames
2 participants