Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReverseProxied middleware and add docs #1873

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Conversation

RobbeSneyders
Copy link
Member

Starlette introduced some new changes to how the root_path is handled, which broke our ReverseProxied example and test.

This PR fixes both and adds documentation on how to run behind a proxy.

@coveralls
Copy link

Coverage Status

coverage: 94.214%. remained the same
when pulling df8abd3 on bugfix/reverse-proxy
into f8f461c on main.

@RobbeSneyders RobbeSneyders merged commit 3e64fe4 into main Feb 11, 2024
8 checks passed
@RobbeSneyders RobbeSneyders deleted the bugfix/reverse-proxy branch February 11, 2024 21:19
mjp4 pushed a commit to mjp4/connexion that referenced this pull request Feb 21, 2024
Starlette introduced some new changes to how the `root_path` is handled,
which broke our `ReverseProxied` example and test.

This PR fixes both and adds documentation on how to run behind a proxy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants