Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/method views args #1564

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

bluebrown
Copy link
Contributor

Fixes #1563

Changes proposed in this pull request:

  • rename DeprecatedMethodViewResolver to MethodResolver
  • use a base class for both MethodResolver and MethodViewResolver
  • pass class args / kwargs to the class instance/as_view function in both resolvers

@coveralls
Copy link

coveralls commented Jul 3, 2022

Pull Request Test Coverage Report for Build 2612518271

  • 18 of 22 (81.82%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 94.683%

Changes Missing Coverage Covered Lines Changed/Added Lines %
connexion/resolver.py 18 22 81.82%
Totals Coverage Status
Change from base Build 2586096914: -0.02%
Covered Lines: 2707
Relevant Lines: 2859

💛 - Coveralls

@RobbeSneyders
Copy link
Member

Thanks @bluebrown, looks good to me.

You do have an orphan commit because I rewrote history on main (to unsquash the black formatting so we can exclude it from history, #1561). It's not an issue, but it will add me as a co-author to this PR. You can rebase on main to remove it.

@bluebrown
Copy link
Contributor Author

Hi @RobbeSneyders, what do you mean by rebase on main?

Do you mean I should squash these 3 commits into 1, in my branch?

@RobbeSneyders
Copy link
Member

The first commit of your PR (9be473d) is outdated. The same changes are now added as separate commits on main. If you rebase on main, you should be able skip the first commit, only keeping the 2 relevant commits.

@bluebrown
Copy link
Contributor Author

Sorry, I don't know how to do that rebase on main.

The only rebasing I know would be like below, on my feature branch.

git rebase -i HEAD~3

Signed-off-by: Nico Braun <rainbowstack@gmail.com>
@RobbeSneyders
Copy link
Member

git rebase main should do it. Just make sure to pull main first so it's up to date.

@bluebrown
Copy link
Contributor Author

bluebrown commented Jul 4, 2022

I have pulled the latest changes before branching. Right now, I cannot fetch upstream because there are no new changes.

image

Pulling my own main, locally also says no changes, and git rebase main in the feature branch as well.

$ connexion on  feature/method-views-args via 🐍 v3.9.2 on ☁️  (eu-central-1) ❯ git rebase main
Current branch feature/method-views-args is up to date

@RobbeSneyders RobbeSneyders merged commit 64f4254 into spec-first:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow MethodResolver and MethodViewResolver
3 participants