Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async tests #1558

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Fix async tests #1558

merged 2 commits into from
Jun 24, 2022

Conversation

Ruwann
Copy link
Member

@Ruwann Ruwann commented Jun 22, 2022

The async tests were getting skipped because we didn't have an appropriate pytest setup for it. This PR aims to fix this and adjusts the tests accordingly.

await wrapped_func(request)

assert exc_info.value.status_code == 403
assert exc_info.value.detail == "Provided token doesn't have the required scope"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is because we are now subclassing connexion exceptions from starlette now, which have a different str representation

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2545700357

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 94.737%

Totals Coverage Status
Change from base Build 2531482884: 0.4%
Covered Lines: 2682
Relevant Lines: 2831

💛 - Coveralls

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ruwann. LGTM.

@RobbeSneyders RobbeSneyders merged commit 6f9117c into spec-first:main Jun 24, 2022
@Ruwann Ruwann deleted the bugfix/async-tests branch April 9, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants