This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Fix Android support check #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2626 |
improbable-prow-robot
added
do-not-merge/work-in-progress
improbable-prow-robot
added
A: build-system
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
|
Woops realised the ticket reference in the branch name is wrong! Its actually UTY-2628 |
|
Kudos, SonarCloud Quality Gate passed!
|
seanjparker
approved these changes
Jul 28, 2020
BryanJY-Wong
approved these changes
Jul 28, 2020
paulbalaji
approved these changes
Jul 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is two bug fixes combined in one!
The first commit is a driveby where selecting the 'Cloud Build Options' and then the 'Local Build Options' and then selecting the
iOStarget would throw errors. TL;DR - We built a cache and forget to clear it when its invalidated.The second is the fix for the associated ticket, if the editor pref isn't set, we look to ensure that the default location for the Android SDK installed by Unity is present.
Tests
Put my build configuration in a configuration that would give me the missing Android SDK error (even though it was installed), then applied the code changes and checked that it correctly identifies it as installed.
Documentation