UTY-2504: Nullable command response #1428
Conversation
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2504 |
improbable-prow-robot
added
jira/UTY
size/M
improbable-prow-robot
added
A: core
| @@ -39,6 +41,20 @@ protected override void OnCreate() | |||
|
|
|||
| protected override void OnUpdate() | |||
| { | |||
| if (lastId.HasValue) | |||
There was a problem hiding this comment.
Do we want to add this to playground?
This might be rather spammy in a cloud build
There was a problem hiding this comment.
It only logs when you left/right-click, but if its still too spammy I can remove it. @jamiebrynes7 @paulbalaji what do you think?
There was a problem hiding this comment.
It might be useful locally, but don't think it's worth keeping for cloud builds
…los/gdk-for-unity into feature/nullable-command-response
| #if UNITY_EDITOR | ||
| lastId = commandSystem.SendCommand(request, entities[0]); | ||
| Debug.Log($"Launching {lastId.Value.Raw}"); | ||
| #else |
There was a problem hiding this comment.
Just checking if you tested this works? I think this now means that it won't send commands in the editor
There was a problem hiding this comment.
😕 if editor send command, store id and log else just send command, and yes I did test it
|
Kudos, SonarCloud Quality Gate passed!
|
Description
The
GetResponse<T>(CommandRequestId)method in theIDiffCommandResponseStorageandCommandSystemnow returns aT?instead ofMessageSpan<T>Tests
Simple validation in the playground's
PlayerCommandSystemDocumentation
How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.