This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Render primitive schema data & enums in the worker inspector #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
jamiebrynes7
force-pushed
the
feature/worker-inspector-primitive-data
branch
from
c9b1c5a
to
a9209c2
Compare
paulbalaji
approved these changes
Jun 8, 2020
...able.gdk.debug/.codegen/Source/Generators/DebugExtensions/ComponentVisualElementGenerator.cs
Outdated
Show resolved
Hide resolved
...able.gdk.debug/.codegen/Source/Generators/DebugExtensions/ComponentVisualElementGenerator.cs
Outdated
Show resolved
Hide resolved
jamiebrynes7
force-pushed
the
feature/worker-inspector-primitive-data
branch
from
a9209c2
to
fc98ef9
Compare
zeroZshadow
approved these changes
Jun 9, 2020
...bable.gdk.tools/.CodeGenTemplate/CodeGenerationLib/Model/Details/FieldTypes/ContainedType.cs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| var humanReadableName = Formatting.SnakeCaseToHumanReadable(fieldDetails.Name); | ||
| yield return $"{fieldDetails.CamelCaseName}Field = new {uiType}(\"{humanReadableName}\");"; |
There was a problem hiding this comment.
Extract the string into a variable: {fieldDetails.CamelCaseName}Field
There was a problem hiding this comment.
I've refactored this a little bit in the user-types branch, will apply this suggestion there 👍
|
Kudos, SonarCloud Quality Gate passed!
|
improbable-prow-robot
deleted the
feature/worker-inspector-primitive-data
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a subset of the component data rendering to the Worker Inspector. It adds support for all schema primitives (except for
Entity) and schema enums. Later PRs will addEntityschema typeNote in f081633 I turned quite a few things public. Discussed a strategy with Paul and will raise a ticket to go back and refactor these to make using them easier in the modular codegen world.
Tests
Eyeball test. Will conduct more exhaustive tests once all the data types are in