Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Icons in the Worker Inspector #1385

Merged
merged 12 commits into from
Jun 15, 2020
Merged

Icons in the Worker Inspector #1385

merged 12 commits into from
Jun 15, 2020

Conversation

jamiebrynes7
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 commented Jun 5, 2020

Description

Fun little change here, I've added icons to each component in the Worker Inspector and allow this to be set via a schema annotation!

image

Tests

  • Standard library components with icons
  • Default icon for components
  • Annotations set the icon

Documentation

  • Changelog

Will also need to make a note of this in the Readme docs.

@improbable-prow-robot improbable-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Jun 5, 2020
@improbable-prow-robot improbable-prow-robot added A: game-object-creation Area: Gameobject creation feature module A: playground Area: Playground A: tooling Area: Tooling A: transform-synchronization Area: Transform synchronization feature module labels Jun 5, 2020
@jamiebrynes7 jamiebrynes7 marked this pull request as ready for review June 12, 2020 10:43
@improbable-prow-robot improbable-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2020
@@ -41,6 +42,8 @@ component Launcher {
command ScoreIncreaseResponse increase_score(ScoreIncreaseRequest);
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

7.1% 7.1% Coverage
0.0% 0.0% Duplication

@jamiebrynes7 jamiebrynes7 merged commit 8adf7d4 into develop Jun 15, 2020
@improbable-prow-robot improbable-prow-robot deleted the feature/fun-icons branch June 15, 2020 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: core Area: Core GDK A: game-object-creation Area: Gameobject creation feature module A: playground Area: Playground A: tooling Area: Tooling A: transform-synchronization Area: Transform synchronization feature module jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants