This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
labels
Jun 5, 2020
improbable-prow-robot
added
A: game-object-creation
Area: Gameobject creation feature module
A: playground
Area: Playground
A: tooling
Area: Tooling
A: transform-synchronization
Area: Transform synchronization feature module
labels
Jun 5, 2020
jamiebrynes7
force-pushed
the
feature/fun-icons
branch
from
June 12, 2020 10:29
2e32b32
to
251b9f3
Compare
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jun 12, 2020
zeroZshadow
approved these changes
Jun 12, 2020
.../unity/Packages/io.improbable.gdk.core/.schema/improbable/gdk/editor/worker_inspector.schema
Outdated
Show resolved
Hide resolved
...ers/unity/Packages/io.improbable.gdk.debug/WorkerInspector/Codegen/ComponentVisualElement.cs
Outdated
Show resolved
Hide resolved
paulbalaji
approved these changes
Jun 15, 2020
schema/playground/launcher.schema
Outdated
@@ -41,6 +42,8 @@ component Launcher { | |||
command ScoreIncreaseResponse increase_score(ScoreIncreaseRequest); | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
jamiebrynes7
commented
Jun 15, 2020
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A: core
Area: Core GDK
A: game-object-creation
Area: Gameobject creation feature module
A: playground
Area: Playground
A: tooling
Area: Tooling
A: transform-synchronization
Area: Transform synchronization feature module
jira/no-ticket
Indicates a PR has no corresponding JIRA ticket
size/M
Denotes a PR that changes 40-149 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fun little change here, I've added icons to each component in the Worker Inspector and allow this to be set via a schema annotation!
Tests
Documentation
Will also need to make a note of this in the Readme docs.