This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Better reference provider #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
do-not-merge/work-in-progress
improbable-prow-robot
added
A: core
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
jamiebrynes7
reviewed
May 7, 2020
test-project/Assets/EditmodeTests/Collections/ReferenceProviderTests.cs
Outdated
Show resolved
Hide resolved
test-project/Assets/EditmodeTests/Collections/ReferenceProviderTests.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Collections/ReferenceProvider.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Collections/ReferenceProvider.cs
Outdated
Show resolved
Hide resolved
workers/unity/Packages/io.improbable.gdk.core/Collections/ReferenceProvider.cs
Show resolved
Hide resolved
zeroZshadow
force-pushed
the
feature/better-reference-provider
branch
from
afa8ddd
to
4a931f4
Compare
jamiebrynes7
approved these changes
May 13, 2020
Replace uint handle with typed ReferenceHandle Move API to handle to abstract the reference provider
Remove redundant world tracking in ReferenceProviders
Add EOF newline
zeroZshadow
force-pushed
the
feature/better-reference-provider
branch
from
4a931f4
to
1497576
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor reference providers to no longer require generated classes.
Use
Handleclasses instead of rawuintto remember type information.Documentation