This repository has been archived by the owner on Jan 18, 2022. It is now read-only.
Fix Readers not re-validating with AggregateSubscription #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace TryGetEntity with GetEntity in area's where we do not test if the entity exists
Avoid capturing component for linking MonoBehaviours, enforce linked component is used.
improbable-prow-robot
added
jira/no-ticket
improbable-prow-robot
added
A: core
paulbalaji
reviewed
Mar 19, 2020
test-project/Assets/EditmodeTests/Subscriptions/RequireablesDisableTests.cs
Show resolved
Hide resolved
austinkelmore
approved these changes
Mar 20, 2020
paulbalaji
approved these changes
Mar 20, 2020
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the mysterious exceptions with injected, but invalid, readers when using QBI.
Some additional safety improvements.
Tests
Added 2 tests, 1 fails without the fix.
Documentation