Skip to content
This repository has been archived by the owner on Jan 18, 2022. It is now read-only.

Codegen bugfixes #1294

Merged
merged 5 commits into from
Feb 18, 2020
Merged

Codegen bugfixes #1294

merged 5 commits into from
Feb 18, 2020

Conversation

paulbalaji
Copy link
Contributor

Description

  • Fixed a bug where the ImprobableCodegen.marker file would not get created despite the code generator returning successfully.
  • Fixed a bug where dotnet output from the code generator would cause exceptions to be thrown.

Tests

  • edited some code, unity compilation didn't trigger code generation
  • introduced bug in csproj, hit generate code, observed logs in unity editor

Documentation

  • changelog

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

Paul Balaji added 3 commits February 18, 2020 12:36
generate codegen marker on successful codegen run, regardless of warn…
4982cfa 
…ings/errors

Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
dotnet/json output processing
9e90cbe 
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
changelog
0cbf2b1
@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket A: tooling Area: Tooling size/M Denotes a PR that changes 40-149 lines, ignoring generated files. labels Feb 18, 2020
jamiebrynes7
jamiebrynes7 approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@jamiebrynes7 jamiebrynes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit on the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@paulbalaji paulbalaji merged commit c2244fa into develop Feb 18, 2020
@paulbalaji paulbalaji deleted the bugfix/codegen-bugfixes branch February 18, 2020 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamiebrynes7 jamiebrynes7 jamiebrynes7 approved these changes

@zeroZshadow zeroZshadow zeroZshadow approved these changes

Assignees
No one assigned
Labels
A: tooling Area: Tooling jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/M Denotes a PR that changes 40-149 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbalaji @zeroZshadow @jamiebrynes7 @improbable-prow-robot