This repository has been archived by the owner on Oct 20, 2021. It is now read-only.
UTY-2690: Enable Burst by default #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanJY-Wong
requested review from
austinkelmore,
zeroZshadow,
seanjparker and
jamiebrynes7
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UTY-2690 |
improbable-prow-robot
added
jira/UTY
size/XS
|
Hmm seems that Burst doesn't support Android compilation out of the box (requires the NDK installed as well). I thought we did have that installed on CI agents, but perhaps not. I'd suggest we leave that one off by default for now? |
jamiebrynes7
approved these changes
Sep 1, 2020
| @@ -11,6 +11,10 @@ | |||
|
|
|||
| - Migrated launch configurations to latest game templates. [#290](https://github.com/spatialos/gdk-for-unity-fps-starter-project/pull/290) | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Enabled Burst by default. [#294](https://github.com/spatialos/gdk-for-unity-fps-starter-project/pull/294) | |||
There was a problem hiding this comment.
I'd probably put this in 'Changed'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabled Burst by default
Tests
How did you test these changes prior to submitting this pull request?
What automated tests are included in this PR?
Documentation
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.