This repository has been archived by the owner on Oct 20, 2021. It is now read-only.
QBI query component filtering #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
paulbalaji
force-pushed
the
feature/qbi-results
branch
from
a91451c
to
6028cfa
Compare
paulbalaji
force-pushed
the
feature/qbi-results
branch
from
b32000a
to
36e881f
Compare
added 4 commits
April 1, 2020 18:24
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
paulbalaji
force-pushed
the
feature/qbi-results
branch
from
cfad802
to
46fb919
Compare
added 3 commits
April 2, 2020 17:07
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
zeroZshadow
approved these changes
Apr 3, 2020
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
jamiebrynes7
approved these changes
Apr 6, 2020
| var clientRangeInterest = InterestQuery.Query(Constraint.RelativeCylinder(clientRadius)).FilterResults(new[] | ||
| { | ||
| Position.ComponentId, Metadata.ComponentId, OwningWorker.ComponentId, | ||
| ServerMovement.ComponentId, ClientRotation.ComponentId, HealthComponent.ComponentId, |
There was a problem hiding this comment.
Do players need other player's health?
There was a problem hiding this comment.
yup, RagdollSpawner requires it
Comment on lines
98
to
108
| var serverSelfInterest = InterestQuery.Query(Constraint.EntityId(entityId)).FilterResults(new[] | ||
| { | ||
| ClientMovement.ComponentId, ShootingComponent.ComponentId | ||
| }); | ||
|
|
||
| var serverRangeInterest = InterestQuery.Query(Constraint.RelativeCylinder(serverRadius)).FilterResults(new[] | ||
| { | ||
| Position.ComponentId, Metadata.ComponentId, OwningWorker.ComponentId, | ||
| ServerMovement.ComponentId, ClientRotation.ComponentId, HealthComponent.ComponentId, | ||
| ShootingComponent.ComponentId | ||
| }); |
There was a problem hiding this comment.
I'm having a little trouble understanding why we chose these sets for the server interest, a comment could help? :)
added 3 commits
April 6, 2020 17:30
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add component filters to qbi queries
drive-by upgrade to latest entities package too
Tests
Documentation
Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.