This repository has been archived by the owner on Oct 20, 2021. It is now read-only.
Cleanup FPS Project for 0.3.0 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improbable-prow-robot
added
jira/no-ticket
zeroZshadow
force-pushed
the
feature/scorched-earth
branch
from
b61dbfd
to
443cc51
Compare
improbable-prow-robot
removed
the
do-not-merge/work-in-progress
added 4 commits
November 8, 2019 16:02
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
Signed-off-by: Paul Balaji <paulbalaji@improbable.io>
jessicafalk
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
took a look at it, moving the files looks good and everything still runs as expected ;)
in the future we should look into whether we can get rid of the movement stuff we did here and replace it with the transform sync and also maybe move all prefabs into one folder (right now we still them in two places depending on how they are used)
zeroZshadow
commented
Nov 11, 2019
Co-Authored-By: Martijn Gerkes <martijn@improbable.io>
paulbalaji
approved these changes
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fps/ScriptsstructureWould highly recommend reviewers should checkout this branch and browse through the structure as part of the review process.
Documentation