This repository has been archived by the owner on Oct 20, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiebrynes7
force-pushed
the
feature/worker-wip
branch
from
June 26, 2019 17:38
df56dce
to
98153d4
Compare
jamiebrynes7
force-pushed
the
feature/worker-wip
branch
from
June 26, 2019 17:39
98153d4
to
81e9fdc
Compare
zeroZshadow
suggested changes
Jun 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run the linter after the changes
workers/unity/Assets/Fps/Scripts/SetupLogic/MobileWorkerConnector.cs
Outdated
Show resolved
Hide resolved
workers/unity/Assets/Fps/Scripts/SetupLogic/SimulatedPlayerCoordinatorWorkerConnector.cs
Outdated
Show resolved
Hide resolved
workers/unity/Assets/Fps/Scripts/SetupLogic/SimulatedPlayerCoordinatorWorkerConnector.cs
Show resolved
Hide resolved
workers/unity/Assets/Fps/Scripts/SetupLogic/SimulatedPlayerCoordinatorWorkerConnector.cs
Outdated
Show resolved
Hide resolved
workers/unity/Assets/Fps/Scripts/SetupLogic/SimulatedPlayerCoordinatorWorkerConnector.cs
Outdated
Show resolved
Hide resolved
workers/unity/Assets/Fps/Scripts/SetupLogic/SimulatedPlayerCoordinatorWorkerConnector.cs
Outdated
Show resolved
Hide resolved
jamiebrynes7
force-pushed
the
feature/worker-wip
branch
from
June 27, 2019 13:43
09d2139
to
4626ea2
Compare
zeroZshadow
approved these changes
Jun 27, 2019
paulbalaji
approved these changes
Jun 27, 2019
workers/unity/Assets/Fps/Scripts/SetupLogic/ClientWorkerConnector.cs
Outdated
Show resolved
Hide resolved
sputn1ck
added a commit
to sputn1ck/gdk-for-unity-fps-starter-project
that referenced
this pull request
Aug 27, 2020
stepSounds, getDmgSound and audioListener fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the FPS Starter Project with the changes made in spatialos/gdk-for-unity#981.
Also did quite a lot of driveby changes on the sim player flow.
Commits are distinct, helpful for reviewing the PR
Tests
Left todo
gdk.pinned
once Worker abstraction rework gdk-for-unity#981 is merged