This repository has been archived by the owner on Oct 20, 2021. It is now read-only.
Upgrade entities #191
Merged
Upgrade entities #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove BlittableBool Fix bug where stopping the game threw an error about removing the authoritative player entity.
paulbalaji
reviewed
Jun 6, 2019
| @@ -45,7 +46,10 @@ protected override void OnUpdate() | |||
| } | |||
| else | |||
| { | |||
| SessionStatus = sessionGroup.GetComponentDataArray<Session.Component>()[0].Status; | |||
| Entities.With(sessionGroup).ForEach((ref Session.Component session) => | |||
There was a problem hiding this comment.
is there any chance that we have more than 1 entity matching this query?
There was a problem hiding this comment.
if you misconfigure it ><
but you should always have at most one session entity in your deployment.
There was a problem hiding this comment.
@jessicafalk I think no?
There was a problem hiding this comment.
as mentioned: our snapshot always only contains at most one entity. A user can of course mess around with it and change it, but we assume you only have it at most once
There was a problem hiding this comment.
Is it oke by you to leave it like this?
There was a problem hiding this comment.
it's not nice, but ok to leave it like this for now. It's not a big issue
paulbalaji
approved these changes
Jun 6, 2019
workers/unity/Packages/com.improbable.gdk.health/Systems/HealthRegenSystem.cs
Show resolved
Hide resolved
workers/unity/Packages/com.improbable.gdk.health/Systems/HealthRegenSystem.cs
Show resolved
Hide resolved
jessicafalk
reviewed
Jun 6, 2019
workers/unity/Assets/Fps/Scripts/SetupLogic/OneTimeInitialisation.cs
Outdated
Show resolved
Hide resolved
jessicafalk
approved these changes
Jun 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade the FPS to use the new Entities API's.
Tests
Ran locally in every scene.
Cloud deployment is currently launching
Documentation
Changelog updated.