Upgrade Karpenter to latest version #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
upgrade-aws-provider-v5
branch
6 times, most recently
from
1598919
to
0398e4b
Compare
mvandenburgh
force-pushed
the
upgrade-aws-provider-v5
branch
from
0fadcbc
to
cfa3260
Compare
jjnesbitt
previously approved these changes
Jul 30, 2024
mvandenburgh
changed the title
mvandenburgh
force-pushed
the
upgrade-aws-provider-v5
branch
from
83d7849
to
19486fd
Compare
mvandenburgh
force-pushed
the
upgrade-aws-provider-v5
branch
2 times, most recently
from
7128300
to
e3623c6
Compare
Note, the `map_public_ip_on_launch` now defaults to `false` in the new version of the module. To maintain the current behavior, we need to explicitly set it to `true`. See https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/master/UPGRADE-4.0.md#additional-changes
Note, this includes the v1beta1 API migrations mentioned here: https://karpenter.sh/v0.32/upgrading/v1beta1-migration/
The `CriticalAddonsOnly` taint is a private taint and using it is a k8s best practice.
mvandenburgh
force-pushed
the
upgrade-aws-provider-v5
branch
from
e3623c6
to
4cee20b
Compare
mvandenburgh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Karpenter to v0.34.6. This includes a major API change in v0.32 - https://karpenter.sh/v0.32/upgrading/v1beta1-migration/