Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test docker image builds on PRs #686

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

mvandenburgh
Copy link
Member

@mvandenburgh mvandenburgh commented Oct 25, 2023

This will make it so a "test build" of docker images (i.e. they will get built but not published to GHCR) gets performed on any PR that makes changes to the images/ directory. This will help catch image build failures before a merge to main happens.

@mvandenburgh mvandenburgh marked this pull request as ready for review October 25, 2023 18:43
Copy link
Collaborator

@scottwittenburg scottwittenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, and seems like the part where it builds on PRs is working. If there's anything wrong with the push condition, we won't know until it's run on main.

@mvandenburgh mvandenburgh merged commit 3732abf into main Oct 25, 2023
16 checks passed
@mvandenburgh mvandenburgh deleted the build-docker-images-in-ci branch October 25, 2023 18:58
@mvandenburgh
Copy link
Member Author

Looks like it is working as expected on main right now -

Run docker/build-push-action@2eb1c1961a95fc15694676618e422e8ba1d63825
  with:
    context: ./images/gh-gl-sync
    file: ./images/gh-gl-sync/Dockerfile
    push: true
    tags: ghcr.io/spack/ci-bridge:0.0.[3](https://github.com/spack/spack-infrastructure/actions/runs/6644910333/job/18055087620#step:6:3)8
    platforms: linux/amd6[4](https://github.com/spack/spack-infrastructure/actions/runs/6644910333/job/18055087620#step:6:4),linux/arm[6](https://github.com/spack/spack-infrastructure/actions/runs/6644910333/job/18055087620#step:6:6)4
    load: false
    no-cache: false
    pull: false
    github-token: ***
GitHub Actions runtime token ACs
Docker info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants