-
-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pdfium-render version #2701
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit 1c84e23.
- Bump the minimum pdfium lib api version (updated bundled lib in native-deps) - Custom fork is still required because upstream added a hard limit on chono version 0.4.31, which is incompatible with some of our dependencies which require newer versions
8d172d2
to
cb1a144
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @matheus-consoli can you test again just to make sure it is working for you too
Edit: No ideia why ESLint CI failed, some weird error during setup, will probably pass after a re-run
working perfectly, thanks @HeavenVolkoff! |
R̶e̶v̶e̶r̶t̶ ̶#̶2̶6̶6̶6̶ ̶a̶n̶d̶ ̶b̶u̶m̶p̶ ̶p̶d̶f̶i̶u̶m̶-̶r̶e̶n̶d̶e̶r̶ ̶v̶e̶r̶s̶i̶o̶n̶.̶
W̶i̶t̶h̶ ̶o̶u̶r̶ ̶c̶u̶r̶r̶e̶n̶t̶ ̶f̶o̶r̶k̶,̶ ̶w̶e̶ ̶r̶e̶c̶e̶i̶v̶e̶ ̶a̶ ̶l̶o̶t̶ ̶o̶f̶ ̶e̶r̶r̶o̶r̶s̶ ̶r̶e̶l̶a̶t̶e̶d̶ ̶t̶o̶ ̶l̶i̶n̶k̶i̶n̶g̶,̶ ̶a̶n̶d̶ ̶t̶h̶e̶ ̶o̶r̶i̶g̶i̶n̶a̶l̶ ̶c̶r̶a̶t̶e̶ ̶m̶e̶r̶g̶e̶d̶ ̶o̶u̶r̶ ̶c̶h̶a̶n̶g̶e̶s̶ ̶(̶t̶h̶a̶n̶k̶s̶ ̶@̶H̶e̶a̶v̶e̶n̶V̶o̶l̶k̶o̶f̶f̶!̶)̶
@HeavenVolkoff: Updated custom fork and increased the minimum required pdfium api, now that native_deps ships the latest pdfium lib. Unfortunately, we still need a custom fork due to upstream adding a hard limit on chono version <= 0.4.31, which is incompatible with some of our dependencies which require newer versions