Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdf thumbnails #2666

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix pdf thumbnails #2666

merged 1 commit into from
Aug 16, 2024

Conversation

HeavenVolkoff
Copy link
Member

Use a fork of pdfium-renderer including the required fix while a new version isn't released

Related:
ajrcarey/pdfium-render#155

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 9:04pm
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 9:04pm

Copy link
Member

@Rocky43007 Rocky43007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@Rocky43007 Rocky43007 added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 1c84e23 Aug 16, 2024
13 checks passed
@Rocky43007 Rocky43007 deleted the fix-pdf-thumbs branch August 16, 2024 21:37
matheus-consoli added a commit that referenced this pull request Sep 11, 2024
HeavenVolkoff pushed a commit that referenced this pull request Sep 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 17, 2024
* Revert "Fix pdf thumbnails (#2666)"

This reverts commit 1c84e23.

* Bump pdfium-render dep

* Bring back custom fork
 - Bump the minimum pdfium lib api version (updated bundled lib in native-deps)
 - Custom fork is still required because upstream added a hard limit on chono version 0.4.31, which is incompatible with some of our dependencies which require newer versions

---------

Co-authored-by: Vítor Vasconcellos <vasconcellos.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants