forked from eclipse-edc/DataDashboard
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance edc UI terminologies for create data offer tab #797
Merged
illfixit
merged 10 commits into
main
from
1420-enhance-edc-ui-terminologies-for-create-data-offer-tab
Sep 2, 2024
Merged
Enhance edc UI terminologies for create data offer tab #797
illfixit
merged 10 commits into
main
from
1420-enhance-edc-ui-terminologies-for-create-data-offer-tab
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdullahMuk
requested changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@illfixit as aligned on the phone, not all acceptance criteria are addressed as listed in https://github.com/sovity/PMO-Software/issues/1420 . Please adjust the solution according to acceptance criteria; then we will review the PR.
Thanks!
…-tab' of https://www.github.com/sovity/edc-ui into 1420-enhance-edc-ui-terminologies-for-create-data-offer-tab
LGTM |
kamilczaja
approved these changes
Sep 2, 2024
AbdullahMuk
approved these changes
Sep 2, 2024
illfixit
deleted the
1420-enhance-edc-ui-terminologies-for-create-data-offer-tab
branch
September 2, 2024 12:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does this PR close?
closes #1420 Enhance EDC-UI terminologies for Create Data Offer tab
Datasource
Preferred E-Mail Subject
Old Hint: "Will be added to the mailto-link and displayed to potential consumers to use."
New Hint: "When potential customers reach out to you via email, you’ll receive messages with this subject line.
General Information
Asset ID (old ID)
Publishing
Publish restricted
Policy Type Dialog:
Participant ID renamed to Consumer's Participant ID
Evaluation Time renamed to Time Restriction
Multi renamed to Combine
Changed the order of the elements in the Dialog to:
Added separation line between "Time Restriction","Timespan Restriction"
Before:
After:
Policy Expressions:
Time Restriction (old Evaluation Time)
Consumer's Participand ID (old Participant's Id)
Create asset only (without data offer) (old "do not publish")
Acceptance Criteria
Checklist