Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance edc UI terminologies for create data offer tab #797

Merged

Conversation

illfixit
Copy link
Collaborator

@illfixit illfixit commented Aug 20, 2024

What issues does this PR close?
closes #1420 Enhance EDC-UI terminologies for Create Data Offer tab

Datasource

Preferred E-Mail Subject

Old Hint: "Will be added to the mailto-link and displayed to potential consumers to use."
New Hint: "When potential customers reach out to you via email, you’ll receive messages with this subject line.

image

General Information

Asset ID (old ID)

image

Publishing

Publish restricted

Policy Type Dialog:
Participant ID renamed to Consumer's Participant ID
Evaluation Time renamed to Time Restriction
Multi renamed to Combine

Changed the order of the elements in the Dialog to:

  • "Consumer's Participant ID"
  • "Time Restriction"
  • "Timespan Restriction"
  • "Combine"

Added separation line between "Time Restriction","Timespan Restriction"

Before:
image
After:
image

Policy Expressions:

Time Restriction (old Evaluation Time)
image

Consumer's Participand ID (old Participant's Id)
image

Create asset only (without data offer) (old "do not publish")

image

Acceptance Criteria

Checklist

@AbdullahMuk AbdullahMuk self-requested a review September 2, 2024 08:57
Copy link
Collaborator

@AbdullahMuk AbdullahMuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@illfixit as aligned on the phone, not all acceptance criteria are addressed as listed in https://github.com/sovity/PMO-Software/issues/1420 . Please adjust the solution according to acceptance criteria; then we will review the PR.

Thanks!

@illfixit illfixit marked this pull request as ready for review September 2, 2024 10:44
@AbdullahMuk
Copy link
Collaborator

LGTM

@illfixit illfixit enabled auto-merge (squash) September 2, 2024 11:02
@illfixit illfixit merged commit b61a216 into main Sep 2, 2024
13 checks passed
@illfixit illfixit deleted the 1420-enhance-edc-ui-terminologies-for-create-data-offer-tab branch September 2, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants