Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize the UI and add a German localization #756

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bearn01d
Copy link

@bearn01d bearn01d commented Jun 27, 2024

As discussed with @SebastianOpriel and @richardtreier, we as Fraunhofer FIT provide an internationalization of the UI alongside a German translation as a PR, as part of the project Datenraum Kultur.

The flag icons used for the English and German localization are taken from here and here, respectively. For both images, the licensing information states that they are in the public domain.

Looking forward to your feedback!

Checklist

@bearn01d bearn01d force-pushed the feature/i18n branch 2 times, most recently from 6a6381f to 8de755b Compare June 28, 2024 09:57
@AbdullahMuk AbdullahMuk linked an issue Jun 30, 2024 that may be closed by this pull request
@tmberthold
Copy link
Member

Hello and thank you for the contribution! 🚀

We will let you know as soon as we know when this cool feature will be on our product roadmap (@AbdullahMuk).

@kulgg
Copy link
Collaborator

kulgg commented Jul 12, 2024

Cool PR! We should merge this as soon as possible. The longer we wait the more merge conflicts will be present. @AbdullahMuk

@richardtreier
Copy link
Collaborator

richardtreier commented Jul 23, 2024

Thank you for your contribution. I apologize for the delayed merge. We've been on a very tight schedule to deliver the upcoming release, thus we could not afford to incorporate this PR into the code base yet.

For the upcoming release (tomorrow) I also do not foresee that we'll have the time to include this.

I recommend we do it after that release.

@bearn01d
Copy link
Author

Thank you for the update, @richardtreier. With @AbdullahMuk, it has been discussed that just before you start the review, we will rebase this branch onto the latest main code to resolve the piled up merge conflicts from the last weeks.

@bearn01d
Copy link
Author

bearn01d commented Aug 2, 2024

I force pushed a rebased version of this feature, resolving the conflicts by accepting all changes made by you in a first step. This is not ready for review yet, because we need to re-add some translations that have to be integrated differently now and add some new translations.

@tmberthold tmberthold marked this pull request as draft August 7, 2024 08:25
@richardtreier
Copy link
Collaborator

I'll go ahead and migrate this code to work with our latest changes.

@richardtreier
Copy link
Collaborator

richardtreier commented Sep 5, 2024

@bearn01d

Hello, I am currently in the progress of refreshing this PR and getting ready to merge.

I see some issues with trying to use the "classic" Apache 2.0 license header comments in the files touched by the PR.

I would like to switch to a NOTICE-file style attribution + copyright: https://infra.apache.org/licensing-howto.html#example-notice, to avoid issues with comments in the multiple file formats, e.g. rendering in DOM, etc.

My suggestion would be:

sovity EDC UI
Copyright (c) 2024. sovity GmbH

This product includes software developed at sovity GmbH (https://www.sovity.de).
Copyright (c) 2024. sovity GmbH

The Initial Internalization of the EDC UI to German was implemented by the
Fraunhofer Institute for Applied Information Technology FIT (https://www.fit.fraunhofer.de/).
Copyright (c) 2024. Fraunhofer Institute for Applied Information Technology FIT

Is that okay with you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Multi-Language Support / Localization
4 participants