-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalize the UI and add a German localization #756
base: main
Are you sure you want to change the base?
Conversation
6a6381f
to
8de755b
Compare
Hello and thank you for the contribution! 🚀 We will let you know as soon as we know when this cool feature will be on our product roadmap (@AbdullahMuk). |
Cool PR! We should merge this as soon as possible. The longer we wait the more merge conflicts will be present. @AbdullahMuk |
Thank you for your contribution. I apologize for the delayed merge. We've been on a very tight schedule to deliver the upcoming release, thus we could not afford to incorporate this PR into the code base yet. For the upcoming release (tomorrow) I also do not foresee that we'll have the time to include this. I recommend we do it after that release. |
Thank you for the update, @richardtreier. With @AbdullahMuk, it has been discussed that just before you start the review, we will rebase this branch onto the latest |
I force pushed a rebased version of this feature, resolving the conflicts by accepting all changes made by you in a first step. This is not ready for review yet, because we need to re-add some translations that have to be integrated differently now and add some new translations. |
I'll go ahead and migrate this code to work with our latest changes. |
Hello, I am currently in the progress of refreshing this PR and getting ready to merge. I see some issues with trying to use the "classic" Apache 2.0 license header comments in the files touched by the PR. I would like to switch to a My suggestion would be:
Is that okay with you? |
0911fa1
to
66426e1
Compare
As discussed with @SebastianOpriel and @richardtreier, we as Fraunhofer FIT provide an internationalization of the UI alongside a German translation as a PR, as part of the project Datenraum Kultur.
The flag icons used for the English and German localization are taken from here and here, respectively. For both images, the licensing information states that they are in the public domain.
Looking forward to your feedback!
Checklist