Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typos #89

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix some typos #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2ff533
s/commiter/committer/
ydah Sep 27, 2022
e06fbed
s/resturns/returns/
ydah Sep 27, 2022
3d63415
s/conditonal/conditional/
ydah Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Your project may have many local rules:
* Should not use `Net::HTTP` for Web API calls, but use `HTTPClient`

These local rule violations will be found during code review.
Reviewers will ask commiter to revise; commiter will fix; fine.
Reviewers will ask committer to revise; committer will fix; fine.
Really?
It is boring and time-consuming.
We need some automation!
Expand Down
2 changes: 1 addition & 1 deletion test/config_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def test_factory_config_returns_empty_config
assert_equal Pathname("/foo/bar"), config.root_dir
end

def test_factory_config_resturns_config_with_rules
resturns def test_factory_config_returns_config_with_rules
config = Config::Factory.new(
{
"rules" => [
Expand Down
2 changes: 1 addition & 1 deletion test/pattern_parser_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def test_any_kinded
assert_instance_of K::Any, pat
end

def test_conditonal_kinded
def test_conditional_kinded
pat = parse_kinded("foo [conditional]")
assert_instance_of K::Conditional, pat
refute pat.negated
Expand Down