fixes #214 #220 #233
Closed
fixes #214 #220 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes `only_if` and mysql query issues with setting password
before starting the service, checks for an initial config file, creates it if it doesn't exist and runs mysqld with init-file argument
minor fix
minor fix, file has :create, not :run...
path got lost somewhere in time
Updated mysqld command to run as root for setting the initial password as per https://dev.mysql.com/doc/refman/5.7/en/changing-mysql-user.html
updates root password, and verifies it was updated
added failsafe to make sure the mysql service is not running
added failsafe to make sure the mysql service is not running
added failsafe to make sure the mysql service is not running
removed reload support as mariadb service does not support it and can be misleading
added presence test for pid_file
fixing issues with kill
fixing issues using kill
apparently the mysqld service is stopped afterwards
improved resource notifications
improved resource notifications
removed `only_if` clause, as `generate-mariadb-root-password` resource already creates the file for us and is required by this resource
removed `only_if` clause, as `generate-mariadb-root-password` resource already creates the file for us and is required by this resource
working out chef resource behaviour...
fixes linting
bad boolean algebra... it would not apply password if there was any mysqld process to kill
|
I just realized a big mistake on the boolean algebra, closing another one... |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mainly fixes setting the root password in the server_install recipe. The way this is achieved is by first killing off any mysql service that may be running (and which are properly registered in /var/run/mysql/mysqld.pid), launching up a mysqld service manually, with an initial script which sets the root password. Then it tries to authenticate with that password, and if it is okay, it kills that process in order to allow the proper mariadb service to start.
Properly checks for the
node['mariadb']['server_root_password']attribute being set, as well as thepasswordproperty being passed.Fixes errors about the way the
only_ifguard is evaluated, it is now evaluated as a code block.Also removed a reference in the integration tests about the
reloadfunction for mariadb service, which does not support this function.Issues Resolved
#214 #220
Check List
tested with kitchen in Ubuntu 16.04 and 18.04, debian doesn't pass tests due to another issue with importing apt-keys (see apt-keys call within apt_repository broken for debian >9.3 chef/chef#7913)
the testing is the recipe not failing by itself