Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profiler cost estimate #2245

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

SanaaHamel
Copy link

Two dumb typos that I noticed. (Should we turn on warnings-as-errors for CI? It would have caught one of the typos.)

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #2245 (68294e6) into master (042ab12) will decrease coverage by 1.88%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
- Coverage   75.79%   73.91%   -1.89%     
==========================================
  Files         454      454              
  Lines       27588    27593       +5     
==========================================
- Hits        20910    20395     -515     
- Misses       6678     7198     +520     
Impacted Files Coverage Δ
src/ast/transform/MagicSet.cpp 91.93% <ø> (+0.12%) ⬆️
src/ast/utility/SipsMetric.cpp 21.71% <33.33%> (+0.37%) ⬆️
src/ast/transform/MinimiseProgram.cpp 100.00% <100.00%> (ø)
src/main.cpp 67.43% <100.00%> (ø)
src/ram/utility/Utils.h 100.00% <100.00%> (ø)
src/interpreter/EqrelIndex.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/include/souffle/datastructure/PiggyList.h 0.00% <0.00%> (-100.00%) ⬇️
src/include/souffle/datastructure/UnionFind.h 0.00% <0.00%> (-95.61%) ⬇️
...nclude/souffle/datastructure/EquivalenceRelation.h 0.00% <0.00%> (-76.77%) ⬇️
src/include/souffle/datastructure/LambdaBTree.h 0.00% <0.00%> (-73.29%) ⬇️
... and 16 more

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@b-scholz
Copy link
Member

b-scholz commented Apr 1, 2022

This is related to issue #2218.

@b-scholz b-scholz merged commit 4cdd345 into souffle-lang:master Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants